avoiding using prefix for check condition #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senthilb-devrev
requested review from
itsTalwar,
vpbs2 and
zaidjan-devrev
as code owners
zaidjan-devrev
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.devrev.ai/devrev/works/ISS-230075
In few widgets in responsive, they have dimensions. having similar prefix, eg., ticket_requestor, ticket_requestor_org, both are expected to be resolved and they are donIds.
Since in our code, we were checking for prefix, when we could have checked directly for equal, it caused a problem and resulted in ticket_requestor_org coming twice in the final export and ticket_requestor not present completly in the export.
Fix is to make the check properly by using equal, as there isn't any transformation on the name of the resolution config table name